Subject: 1394: fix for recently added firewire patch that breaks things on ppc From: Danny Tholen Recently a patch was added for preliminary suspend/resume handling on !PPC_PMAC. However, this broke both suspend and firewire on powerpc because it saves the pci state after the device has already been disabled. This moves the save state to before the pmac specific code. Signed-off-by: Danny Tholen Acked-by: Benjamin Herrenschmidt Signed-off-by: Andrew Morton Index: linux-2.6.18-rc4/drivers/ieee1394/ohci1394.c =================================================================== --- linux-2.6.18-rc4.orig/drivers/ieee1394/ohci1394.c 2006-08-27 12:27:59.000000000 +0200 +++ linux-2.6.18-rc4/drivers/ieee1394/ohci1394.c 2006-08-27 12:38:21.000000000 +0200 @@ -3552,6 +3552,8 @@ static int ohci1394_pci_resume (struct p static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state) { + pci_save_state(pdev); + #ifdef CONFIG_PPC_PMAC if (machine_is(powermac)) { struct device_node *of_node; @@ -3563,8 +3565,6 @@ static int ohci1394_pci_suspend (struct } #endif - pci_save_state(pdev); - return 0; }