Date: Sat, 26 Dec 2009 01:34:29 +0100 (CET) From: Stefan Richter Subject: firewire: cdev: fix another memory leak in an error path If copy_from_user in an FW_CDEV_IOC_SEND_RESPONSE ioctl failed, the fw_request pointed to by the inbound_transaction_resource is no longer referenced and needs to be freed. Signed-off-by: Stefan Richter --- drivers/firewire/core-cdev.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6.33-rc2/drivers/firewire/core-cdev.c =================================================================== --- linux-2.6.33-rc2.orig/drivers/firewire/core-cdev.c +++ linux-2.6.33-rc2/drivers/firewire/core-cdev.c @@ -723,6 +723,7 @@ static int ioctl_send_response(struct cl if (copy_from_user(r->data, u64_to_uptr(request->data), r->length)) { ret = -EFAULT; + kfree(r->request); goto out; } fw_send_response(client->device->card, r->request,