From ba06b2cbad2b97ee107667ab511f40b9be4f6846 Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Wed, 28 May 2014 00:14:38 +0900 Subject: [PATCH 52/61] ALSA: fireworks: Fix wrong value as argument for PTR_ERR() The return value of memdup_user() should be passed to return correct error. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai --- sound/firewire/fireworks/fireworks_hwdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/fireworks/fireworks_hwdep.c b/sound/firewire/fireworks/fireworks_hwdep.c index 6b50a6796d22..4f8216fb6b62 100644 --- a/sound/firewire/fireworks/fireworks_hwdep.c +++ b/sound/firewire/fireworks/fireworks_hwdep.c @@ -135,7 +135,7 @@ hwdep_write(struct snd_hwdep *hwdep, const char __user *data, long count, buf = memdup_user(data, count); if (IS_ERR(buf)) - return PTR_ERR(data); + return PTR_ERR(buf); /* check seqnum is not for kernel-land */ seqnum = be32_to_cpu(((struct snd_efw_transaction *)buf)->seqnum); -- 1.8.5.5